Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Test default bytecode size increase percent of 0 #7250

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

chore(ci): Test default bytecode size increase percent of 0 #7250

wants to merge 16 commits into from

Conversation

vezenovm
Copy link
Contributor

Description

Problem*

Resolves

Summary*

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions[bot]
github-actions bot reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Memory'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 85189aa Previous: 97073b2 Ratio
rollup-block-root 4910 MB 1230 MB 3.99

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

github-actions[bot]
github-actions bot reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 85189aa Previous: 97073b2 Ratio
noir-lang_mimc_ 1 s 0 s +∞

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

Changes to Brillig bytecode sizes

Generated at commit: 3e610c4aa092ae397cf63c9ea02f3b361cf5843b, compared to commit: 97073b2af2b8527c6332fe1f621adef6b9460ee6

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
array_eq_inliner_max +312 ❌ +328.42%
array_eq_inliner_zero +312 ❌ +328.42%
array_neq_inliner_max +250 ❌ +257.73%
array_neq_inliner_zero +250 ❌ +257.73%
brillig_blake2s_inliner_max +312 ❌ +222.86%
brillig_blake2s_inliner_zero +312 ❌ +222.86%
7_inliner_max +312 ❌ +218.18%
blake3_inliner_max +312 ❌ +218.18%
7_inliner_zero +312 ❌ +218.18%
blake3_inliner_zero +312 ❌ +218.18%
loop_inliner_max +50 ❌ +185.19%
loop_inliner_zero +50 ❌ +185.19%
global_consts_inliner_max +242 ❌ +107.08%
global_consts_inliner_zero +242 ❌ +107.08%
regression_11294_inliner_max +254 ❌ +97.32%
brillig_rc_regression_6123_inliner_max -149 ✅ -88.17%
brillig_rc_regression_6123_inliner_zero -149 ✅ -88.17%
global_var_regression_entry_points_inliner_min -133,686 ✅ -99.93%
global_var_regression_entry_points_inliner_zero -133,686 ✅ -99.95%
Full diff report 👇
Program Brillig opcodes (+/-) %
array_eq_inliner_max 407 (+312) +328.42%
array_eq_inliner_zero 407 (+312) +328.42%
array_neq_inliner_max 347 (+250) +257.73%
array_neq_inliner_zero 347 (+250) +257.73%
brillig_blake2s_inliner_max 452 (+312) +222.86%
brillig_blake2s_inliner_zero 452 (+312) +222.86%
7_inliner_max 455 (+312) +218.18%
blake3_inliner_max 455 (+312) +218.18%
7_inliner_zero 455 (+312) +218.18%
blake3_inliner_zero 455 (+312) +218.18%
loop_inliner_max 77 (+50) +185.19%
loop_inliner_zero 77 (+50) +185.19%
global_consts_inliner_max 468 (+242) +107.08%
global_consts_inliner_zero 468 (+242) +107.08%
regression_11294_inliner_max 515 (+254) +97.32%
keccak256_inliner_max 3,464 (+1,356) +64.33%
sha2_byte_inliner_max 3,444 (+1,322) +62.30%
sha2_byte_inliner_zero 3,452 (+1,230) +55.36%
bigint_inliner_max 3,150 (+1,044) +49.57%
regression_4449_inliner_max 1,085 (+348) +47.22%
sha256_var_witness_const_regression_inliner_zero 1,172 (+361) +44.51%
6_inliner_zero 1,204 (+361) +42.82%
array_dynamic_blackbox_input_inliner_max 1,194 (+348) +41.13%
sha256_var_size_regression_inliner_max 2,423 (+699) +40.55%
sha256_inliner_max 3,274 (+941) +40.33%
array_dynamic_nested_blackbox_input_inliner_max 1,217 (+349) +40.21%
ecdsa_secp256k1_inliner_max 1,238 (+347) +38.95%
conditional_regression_short_circuit_inliner_zero 1,285 (+360) +38.92%
6_inliner_max 1,540 (+385) +33.33%
regression_4449_inliner_zero 1,030 (+256) +33.07%
sha256_var_size_regression_inliner_zero 1,462 (+360) +32.67%
conditional_regression_short_circuit_inliner_max 1,613 (+385) +31.35%
sha256_var_witness_const_regression_inliner_max 1,661 (+387) +30.38%
sha256_var_padding_regression_inliner_max 6,476 (+1,492) +29.94%
ecdsa_secp256k1_inliner_zero 1,186 (+268) +29.19%
array_dynamic_nested_blackbox_input_inliner_zero 1,151 (+256) +28.60%
sha256_regression_inliner_max 8,631 (+1,870) +27.66%
array_dynamic_blackbox_input_inliner_zero 1,296 (+264) +25.58%
aes128_encrypt_inliner_max 525 (+105) +25.00%
fold_2_to_17_inliner_max 699 (+137) +24.38%
6_array_inliner_max 475 (+89) +23.06%
bench_2_to_17_inliner_max 387 (+69) +21.70%
poseidon2_inliner_max 394 (+69) +21.23%
regression_6674_3_inliner_max 611 (+105) +20.75%
regression_6674_3_inliner_zero 611 (+105) +20.75%
6_array_inliner_zero 533 (+88) +19.78%
6_array_inliner_min 543 (+88) +19.34%
conditional_1_inliner_max 1,366 (+220) +19.20%
no_predicates_numeric_generic_poseidon_inliner_max 865 (+136) +18.66%
fold_numeric_generic_poseidon_inliner_max 865 (+136) +18.66%
loop_inliner_min 130 (+20) +18.18%
slice_loop_inliner_zero 377 (+57) +17.81%
keccak256_inliner_zero 2,200 (+225) +11.39%
hint_black_box_inliner_max 350 (+21) +6.38%
to_bits_inliner_min 219 (+10) +4.78%
strings_inliner_zero 978 (+41) +4.38%
ram_blowup_regression_inliner_max 980 (+38) +4.03%
regression_5252_inliner_max 4,621 (+165) +3.70%
poseidon_bn254_hash_width_3_inliner_zero 4,844 (+142) +3.02%
poseidon_bn254_hash_inliner_zero 4,844 (+142) +3.02%
struct_inputs_inliner_zero 264 (+7) +2.72%
brillig_rc_regression_6123_inliner_min 242 (+6) +2.54%
sha256_brillig_performance_regression_inliner_max 1,705 (+38) +2.28%
poseidonsponge_x5_254_inliner_max 4,196 (+80) +1.94%
sha256_var_size_regression_inliner_min 1,280 (+22) +1.75%
regression_inliner_min 1,140 (+18) +1.60%
sha2_byte_inliner_min 3,054 (+48) +1.60%
array_to_slice_inliner_min 1,033 (+15) +1.47%
poseidon_bn254_hash_inliner_min 5,120 (+72) +1.43%
poseidon_bn254_hash_width_3_inliner_min 5,120 (+72) +1.43%
no_predicates_numeric_generic_poseidon_inliner_min 649 (+8) +1.25%
fold_numeric_generic_poseidon_inliner_min 649 (+8) +1.25%
global_consts_inliner_min 268 (+3) +1.13%
hashmap_inliner_min 9,917 (+87) +0.89%
sha256_inliner_zero 1,260 (+11) +0.88%
hashmap_inliner_zero 7,948 (+60) +0.76%
u128_inliner_zero 1,991 (+11) +0.56%
sha256_var_padding_regression_inliner_zero 2,979 (+11) +0.37%
sha256_regression_inliner_zero 4,891 (+11) +0.23%
conditional_1_inliner_min 1,425 (-2) -0.14%
slice_regex_inliner_min 2,121 (-6) -0.28%
hashmap_inliner_max 19,710 (-56) -0.28%
sha256_regression_inliner_min 5,299 (-19) -0.36%
sha256_var_padding_regression_inliner_min 3,225 (-19) -0.59%
higher_order_functions_inliner_zero 730 (-5) -0.68%
tuple_inputs_inliner_min 307 (-3) -0.97%
tuple_inputs_inliner_zero 307 (-3) -0.97%
fold_complex_outputs_inliner_min 700 (-7) -0.99%
sha256_brillig_performance_regression_inliner_min 1,840 (-19) -1.02%
higher_order_functions_inliner_min 1,340 (-15) -1.11%
sha256_inliner_min 1,383 (-19) -1.36%
array_dynamic_blackbox_input_inliner_min 1,266 (-19) -1.48%
ecdsa_secp256k1_inliner_min 1,204 (-19) -1.55%
array_dynamic_nested_blackbox_input_inliner_min 1,191 (-19) -1.57%
ram_blowup_regression_inliner_min 1,129 (-19) -1.66%
conditional_regression_short_circuit_inliner_min 1,102 (-19) -1.69%
brillig_cow_regression_inliner_zero 2,086 (-37) -1.74%
regression_4449_inliner_min 1,057 (-19) -1.77%
6_inliner_min 1,001 (-19) -1.86%
sha256_var_witness_const_regression_inliner_min 975 (-19) -1.91%
sha256_brillig_performance_regression_inliner_zero 1,665 (-42) -2.46%
conditional_1_inliner_zero 1,091 (-35) -3.11%
u128_inliner_max 2,600 (-96) -3.56%
ram_blowup_regression_inliner_zero 918 (-37) -3.87%
slice_regex_inliner_max 2,203 (-116) -5.00%
array_to_slice_inliner_zero 709 (-41) -5.47%
brillig_cow_regression_inliner_max 1,956 (-132) -6.32%
brillig_cow_regression_inliner_min 2,182 (-197) -8.28%
poseidon_bn254_hash_inliner_max 4,753 (-520) -9.86%
poseidon_bn254_hash_width_3_inliner_max 4,753 (-520) -9.86%
struct_inputs_inliner_max 244 (-28) -10.29%
uhashmap_inliner_max 11,379 (-1,349) -10.60%
strings_inliner_max 846 (-106) -11.13%
slices_inliner_zero 1,843 (-249) -11.90%
brillig_cow_inliner_max 324 (-47) -12.67%
slices_inliner_max 1,859 (-273) -12.80%
higher_order_functions_inliner_max 492 (-73) -12.92%
encrypted_log_regression_inliner_min 246 (-43) -14.88%
encrypted_log_regression_inliner_max 233 (-43) -15.58%
encrypted_log_regression_inliner_zero 233 (-43) -15.58%
nested_array_dynamic_inliner_max 1,940 (-487) -20.07%
simple_shield_inliner_max 655 (-171) -20.70%
nested_array_in_slice_inliner_max 894 (-238) -21.02%
tuple_inputs_inliner_max 267 (-73) -21.47%
pedersen_commitment_inliner_zero 134 (-55) -29.10%
simple_shield_inliner_min 609 (-254) -29.43%
to_bits_inliner_max 136 (-58) -29.90%
to_bits_inliner_zero 136 (-58) -29.90%
pedersen_check_inliner_max 353 (-157) -30.78%
brillig_pedersen_inliner_max 353 (-157) -30.78%
simple_shield_inliner_zero 484 (-238) -32.96%
regression_inliner_zero 643 (-326) -33.64%
regression_inliner_max 606 (-326) -34.98%
7_function_inliner_max 356 (-203) -36.31%
array_to_slice_inliner_max 447 (-255) -36.32%
regression_bignum_inliner_max 199 (-117) -37.03%
regression_bignum_inliner_zero 199 (-117) -37.03%
pedersen_check_inliner_min 343 (-214) -38.42%
brillig_pedersen_inliner_min 343 (-214) -38.42%
generics_inliner_zero 99 (-62) -38.51%
regression_struct_array_conditional_inliner_max 318 (-228) -41.76%
regression_struct_array_conditional_inliner_min 318 (-228) -41.76%
regression_struct_array_conditional_inliner_zero 318 (-228) -41.76%
merkle_insert_inliner_min 286 (-210) -42.34%
fold_complex_outputs_inliner_zero 317 (-240) -43.09%
brillig_pedersen_inliner_zero 283 (-216) -43.29%
pedersen_check_inliner_zero 283 (-216) -43.29%
merkle_insert_inliner_zero 257 (-208) -44.73%
merkle_insert_inliner_max 349 (-356) -50.50%
global_var_regression_simple_inliner_min 73 (-94) -56.29%
pedersen_hash_inliner_min 143 (-215) -60.06%
pedersen_hash_inliner_zero 127 (-207) -61.98%
pedersen_hash_inliner_max 124 (-210) -62.87%
global_var_regression_simple_inliner_max 34 (-69) -66.99%
global_var_regression_simple_inliner_zero 34 (-69) -66.99%
side_effects_constrain_array_inliner_max 37 (-85) -69.67%
generics_inliner_max 26 (-64) -71.11%
fold_complex_outputs_inliner_max 100 (-368) -78.63%
brillig_rc_regression_6123_inliner_max 20 (-149) -88.17%
brillig_rc_regression_6123_inliner_zero 20 (-149) -88.17%
global_var_regression_entry_points_inliner_min 98 (-133,686) -99.93%
global_var_regression_entry_points_inliner_zero 71 (-133,686) -99.95%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025 •
edited
Loading

Changes to number of Brillig opcodes executed

Generated at commit: 3e610c4aa092ae397cf63c9ea02f3b361cf5843b, compared to commit: 97073b2af2b8527c6332fe1f621adef6b9460ee6

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
loop_inliner_max +105 ❌ +456.52%
loop_inliner_zero +105 ❌ +456.52%
global_var_regression_simple_inliner_max -86 ✅ -75.44%
global_var_regression_simple_inliner_zero -86 ✅ -75.44%
pedersen_hash_inliner_max -368 ✅ -76.03%
merkle_insert_inliner_zero -2,780 ✅ -76.42%
regression_inliner_max -2,049 ✅ -76.63%
regression_struct_array_conditional_inliner_max -1,165 ✅ -79.20%
regression_struct_array_conditional_inliner_min -1,165 ✅ -79.20%
regression_struct_array_conditional_inliner_zero -1,165 ✅ -79.20%
merkle_insert_inliner_max -2,834 ✅ -80.90%
generics_inliner_max -104 ✅ -82.54%
fold_complex_outputs_inliner_max -662 ✅ -90.19%
brillig_rc_regression_6123_inliner_max -270 ✅ -93.75%
brillig_rc_regression_6123_inliner_zero -270 ✅ -93.75%
global_var_regression_entry_points_inliner_min -135,298 ✅ -99.90%
global_var_regression_entry_points_inliner_zero -135,244 ✅ -99.95%
Full diff report 👇
Program Brillig opcodes (+/-) %
loop_inliner_max 128 (+105) +456.52%
loop_inliner_zero 128 (+105) +456.52%
loop_inliner_min 223 (+51) +29.65%
array_to_slice_inliner_min 2,450 (+189) +8.36%
higher_order_functions_inliner_min 2,350 (+59) +2.58%
hint_black_box_inliner_max 691 (+16) +2.37%
sha2_byte_inliner_min 90,113 (+642) +0.72%
slice_regex_inliner_min 8,669 (+32) +0.37%
ram_blowup_regression_inliner_min 819,618 (-81) -0.01%
ram_blowup_regression_inliner_max 683,818 (-368) -0.05%
brillig_cow_regression_inliner_min 544,276 (-347) -0.06%
hashmap_inliner_min 90,363 (-59) -0.07%
ram_blowup_regression_inliner_zero 814,899 (-542) -0.07%
brillig_cow_regression_inliner_zero 540,559 (-467) -0.09%
hashmap_inliner_zero 74,591 (-85) -0.11%
brillig_cow_regression_inliner_max 454,759 (-634) -0.14%
sha256_var_padding_regression_inliner_min 231,741 (-405) -0.17%
sha256_var_padding_regression_inliner_zero 230,242 (-405) -0.18%
sha256_brillig_performance_regression_inliner_min 26,819 (-81) -0.30%
sha256_regression_inliner_min 157,230 (-486) -0.31%
sha256_regression_inliner_zero 155,188 (-486) -0.31%
array_dynamic_blackbox_input_inliner_min 22,236 (-162) -0.72%
ecdsa_secp256k1_inliner_min 8,129 (-81) -0.99%
sha256_var_size_regression_inliner_min 21,966 (-222) -1.00%
u128_inliner_zero 40,403 (-570) -1.39%
fold_numeric_generic_poseidon_inliner_min 5,763 (-95) -1.62%
no_predicates_numeric_generic_poseidon_inliner_min 5,763 (-95) -1.62%
conditional_regression_short_circuit_inliner_min 4,899 (-81) -1.63%
array_dynamic_nested_blackbox_input_inliner_min 4,885 (-81) -1.63%
global_consts_inliner_min 1,681 (-28) -1.64%
6_inliner_min 4,793 (-81) -1.66%
sha256_brillig_performance_regression_inliner_max 21,659 (-368) -1.67%
regression_6674_3_inliner_max 1,379 (-24) -1.71%
regression_6674_3_inliner_zero 1,379 (-24) -1.71%
sha256_inliner_min 12,123 (-243) -1.97%
sha256_var_witness_const_regression_inliner_min 7,632 (-162) -2.08%
regression_4449_inliner_min 263,933 (-5,670) -2.10%
sha256_brillig_performance_regression_inliner_zero 25,959 (-560) -2.11%
sha256_inliner_zero 11,187 (-243) -2.13%
keccak256_inliner_zero 31,041 (-683) -2.15%
u128_inliner_max 23,729 (-554) -2.28%
sha256_var_padding_regression_inliner_max 191,726 (-5,222) -2.65%
poseidon_bn254_hash_inliner_min 180,375 (-5,598) -3.01%
poseidon_bn254_hash_width_3_inliner_min 180,375 (-5,598) -3.01%
higher_order_functions_inliner_zero 1,286 (-48) -3.60%
slice_loop_inliner_zero 1,221 (-52) -4.08%
sha256_regression_inliner_max 107,286 (-4,844) -4.32%
sha2_byte_inliner_zero 68,803 (-3,566) -4.93%
conditional_1_inliner_min 5,690 (-309) -5.15%
brillig_rc_regression_6123_inliner_min 349 (-19) -5.16%
slice_regex_inliner_max 3,073 (-180) -5.53%
6_array_inliner_min 2,397 (-164) -6.40%
uhashmap_inliner_max 128,710 (-8,810) -6.41%
array_dynamic_blackbox_input_inliner_max 16,390 (-1,139) -6.50%
6_array_inliner_zero 2,327 (-164) -6.58%
fold_complex_outputs_inliner_min 1,009 (-76) -7.00%
array_dynamic_blackbox_input_inliner_zero 19,804 (-1,507) -7.07%
tuple_inputs_inliner_min 598 (-49) -7.57%
tuple_inputs_inliner_zero 598 (-49) -7.57%
sha2_byte_inliner_max 40,756 (-3,351) -7.60%
regression_11294_inliner_max 1,142 (-97) -7.83%
sha256_var_size_regression_inliner_zero 19,706 (-1,727) -8.06%
to_bits_inliner_min 683 (-61) -8.20%
poseidon_bn254_hash_inliner_zero 166,239 (-16,246) -8.90%
poseidon_bn254_hash_width_3_inliner_zero 166,239 (-16,246) -8.90%
sha256_var_size_regression_inliner_max 14,129 (-1,597) -10.16%
fold_numeric_generic_poseidon_inliner_max 4,280 (-490) -10.27%
no_predicates_numeric_generic_poseidon_inliner_max 4,280 (-490) -10.27%
6_array_inliner_max 1,374 (-163) -10.61%
poseidon2_inliner_max 602 (-75) -11.08%
ecdsa_secp256k1_inliner_max 5,667 (-772) -11.99%
encrypted_log_regression_inliner_min 791 (-112) -12.40%
ecdsa_secp256k1_inliner_zero 6,668 (-963) -12.62%
encrypted_log_regression_inliner_max 774 (-112) -12.64%
encrypted_log_regression_inliner_zero 774 (-112) -12.64%
conditional_1_inliner_max 4,448 (-656) -12.85%
regression_4449_inliner_max 176,172 (-26,163) -12.93%
bench_2_to_17_inliner_max 493,457 (-76,779) -13.46%
fold_2_to_17_inliner_max 910,594 (-146,039) -13.82%
conditional_1_inliner_zero 4,720 (-810) -14.65%
keccak256_inliner_max 26,125 (-4,539) -14.80%
array_to_slice_inliner_zero 1,670 (-295) -15.01%
hashmap_inliner_max 41,043 (-7,338) -15.17%
slices_inliner_zero 3,040 (-562) -15.60%
conditional_regression_short_circuit_inliner_max 5,875 (-1,140) -16.25%
6_inliner_max 5,797 (-1,140) -16.43%
7_function_inliner_max 1,850 (-369) -16.63%
regression_4449_inliner_zero 188,682 (-39,695) -17.38%
sha256_var_witness_const_regression_inliner_max 5,311 (-1,138) -17.65%
array_dynamic_nested_blackbox_input_inliner_max 3,489 (-771) -18.10%
slices_inliner_max 2,675 (-601) -18.35%
sha256_var_witness_const_regression_inliner_zero 5,701 (-1,300) -18.57%
conditional_regression_short_circuit_inliner_zero 3,689 (-852) -18.76%
6_inliner_zero 3,611 (-850) -19.05%
aes128_encrypt_inliner_max 2,326 (-553) -19.21%
sha256_inliner_max 10,860 (-2,822) -20.63%
to_bits_inliner_max 455 (-121) -21.01%
to_bits_inliner_zero 455 (-121) -21.01%
array_dynamic_nested_blackbox_input_inliner_zero 3,526 (-986) -21.85%
higher_order_functions_inliner_max 705 (-202) -22.27%
poseidon_bn254_hash_inliner_max 117,751 (-33,988) -22.40%
poseidon_bn254_hash_width_3_inliner_max 117,751 (-33,988) -22.40%
struct_inputs_inliner_zero 456 (-148) -24.50%
strings_inliner_zero 1,574 (-527) -25.08%
poseidonsponge_x5_254_inliner_max 126,169 (-45,357) -26.44%
regression_5252_inliner_max 627,213 (-227,008) -26.57%
global_consts_inliner_max 1,131 (-492) -30.31%
global_consts_inliner_zero 1,131 (-492) -30.31%
array_neq_inliner_max 792 (-398) -33.45%
array_neq_inliner_zero 792 (-398) -33.45%
array_eq_inliner_max 790 (-398) -33.50%
array_eq_inliner_zero 790 (-398) -33.50%
pedersen_commitment_inliner_zero 146 (-82) -35.96%
nested_array_dynamic_inliner_max 2,174 (-1,231) -36.15%
struct_inputs_inliner_max 360 (-209) -36.73%
7_inliner_max 649 (-398) -38.01%
blake3_inliner_max 649 (-398) -38.01%
7_inliner_zero 649 (-398) -38.01%
blake3_inliner_zero 649 (-398) -38.01%
brillig_blake2s_inliner_max 646 (-398) -38.12%
brillig_blake2s_inliner_zero 646 (-398) -38.12%
tuple_inputs_inliner_max 336 (-257) -43.34%
nested_array_in_slice_inliner_max 806 (-656) -44.87%
fold_complex_outputs_inliner_zero 517 (-427) -45.23%
generics_inliner_zero 123 (-102) -45.33%
strings_inliner_max 928 (-818) -46.85%
brillig_pedersen_inliner_min 492 (-440) -47.21%
pedersen_check_inliner_min 492 (-440) -47.21%
brillig_pedersen_inliner_max 380 (-340) -47.22%
pedersen_check_inliner_max 380 (-340) -47.22%
simple_shield_inliner_min 1,341 (-1,240) -48.04%
brillig_cow_inliner_max 528 (-569) -51.87%
brillig_pedersen_inliner_zero 339 (-410) -54.74%
pedersen_check_inliner_zero 339 (-410) -54.74%
array_to_slice_inliner_max 712 (-925) -56.51%
simple_shield_inliner_max 1,091 (-1,421) -56.57%
simple_shield_inliner_zero 963 (-1,533) -61.42%
merkle_insert_inliner_min 1,276 (-2,150) -62.76%
global_var_regression_simple_inliner_min 79 (-135) -63.08%
regression_bignum_inliner_max 178 (-312) -63.67%
regression_bignum_inliner_zero 178 (-312) -63.67%
pedersen_hash_inliner_min 183 (-365) -66.61%
side_effects_constrain_array_inliner_max 27 (-55) -67.07%
regression_inliner_zero 671 (-2,049) -75.33%
pedersen_hash_inliner_zero 119 (-365) -75.41%
global_var_regression_simple_inliner_max 28 (-86) -75.44%
global_var_regression_simple_inliner_zero 28 (-86) -75.44%
pedersen_hash_inliner_max 116 (-368) -76.03%
merkle_insert_inliner_zero 858 (-2,780) -76.42%
regression_inliner_max 625 (-2,049) -76.63%
regression_struct_array_conditional_inliner_max 306 (-1,165) -79.20%
regression_struct_array_conditional_inliner_min 306 (-1,165) -79.20%
regression_struct_array_conditional_inliner_zero 306 (-1,165) -79.20%
merkle_insert_inliner_max 669 (-2,834) -80.90%
generics_inliner_max 22 (-104) -82.54%
fold_complex_outputs_inliner_max 72 (-662) -90.19%
brillig_rc_regression_6123_inliner_max 18 (-270) -93.75%
brillig_rc_regression_6123_inliner_zero 18 (-270) -93.75%
global_var_regression_entry_points_inliner_min 134 (-135,298) -99.90%
global_var_regression_entry_points_inliner_zero 67 (-135,244) -99.95%

@vezenovm vezenovm changed the base branch from mv/more-agg-small-loop-unrolling to master January 31, 2025 19:47
github-actions[bot]
github-actions bot reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: c4f767c Previous: 0c6c637 Ratio
sha256_regression 0.077 s 0.051 s 1.51

This comment was automatically generated by workflow using github-action-benchmark.

CC: @TomAFrench

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vezenovm